Open
Conversation
- Status register of Serial3 (UART2_S1) was hard coded regardless of Serial port used - Added pointer to status register which is initialised depending on Serial port used - Now, SDI-12 runs on serial ports 1, 2 and 3
- Removed isActive() request - changeAddress() sets ioActive, then, isActive() tests again ioActive and returns an error - changeAddress() is only function using isActive()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again,
this pull request includes the other fix with the Serial. So I think you could either merge the other one first and than this one, or only this one and close the other one. Only if you are satisfied with the result of course.
Issue
Function changeAddress() always returns -4 and never sends anyting via the data line.
Problem
ioActive() is tested and set in the very beginning of the function. A subsequent call of isActive() does the very same thing and since ioActive has been set already, isActive() will here always return -4 as error.
Solution
Since changeAddress() is the only function calling isActive() the easiest solution would be to delete the call of isActive() entirely.